Adds functionality for patch-based configuration #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## vara-dev #839 +/- ##
============================================
+ Coverage 68.30% 68.34% +0.04%
============================================
Files 333 334 +1
Lines 25762 25856 +94
============================================
+ Hits 17597 17672 +75
- Misses 8165 8184 +19
☔ View full report in Codecov by Sentry. |
vulder
approved these changes
Sep 26, 2023
Thing is, you cannot type-hint lambdas. One solution would be to make it a function instead (which is a bit overkill imo). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compile-time configurable projects can now be configured using patches.
Therefore, patches can specify a list of
feature_tags.Case studies can contain a configuration map with
PatchConfigurations that contains a mapping from config id to a list of feature tags associated with this configuration.Configuration patches are selected by matching their feature tags to the feature tags of the given configuration.
Since there are multiple types of configuration maps now, their type must be specified using the key
config_typein case study files.